19941

MSXML's loadXML fails to load even well formed xml

I have written a wrapper on top of MSXML in c++ . The load method looks like as below. The problem with the code is it fails to load well formed xml sometimes.

Before passing the xml as string I do a string search for xmlns and replace all occurrence of xmlns with xmlns:dns. In the code below I remove bom character. Then i try to load using the MSXML loadXML method . If load succeeds I set the namespace as shown in the code.

Class XmlDocument{ MSXML2::IXMLDOMDocument2Ptr spXMLDOM; .... }

// XmlDocument methods

void XmlDocument::Initialize() { CoInitialize(NULL); HRESULT hr = spXMLDOM.CreateInstance(__uuidof(MSXML2::DOMDocument60)); if ( FAILED(hr) ) { throw "Unable to create MSXML:: DOMDocument object"; } }

bool XmlDocument::LoadXml(const char* xmltext) { if(spXMLDOM != NULL) { char BOM[3] = {0xEF,0xBB,0xBF}; //detect unicode BOM character if(strncmp(xmltext,BOM,sizeof(BOM)) == 0) { xmltext += 3; } VARIANT_BOOL bSuccess = spXMLDOM->loadXML(A2BSTR(xmltext)); if ( bSuccess == VARIANT_TRUE) { spXMLDOM->setProperty("SelectionNamespaces","xmlns:dns=\"http://www.w3.org/2005/Atom\""); return true; } } return false; }

I tried to debug still could not figure why sometimes loadXML() fails to load even well formed xmls. What am I doing wrong in the code. Any help is greatly appreciated.

Thanks JeeZ

Answer1:

For this specific issue, please refer to Strings Passed to loadXML must be UTF-16 Encoded BSTRs.

Overall, xml parser is not designed for in memory string parsing, e.g. loadXML does not recognize BOM, and it has restriction on the encoding. Rather, an xml parser is designed for byte array form with encoding detection, which is critical for a standard parser. To better leverage MSXML, please consider loading from IStream or a Win32 file.

Answer2:

I'm not a fan of A2BSTR - at the very least you're leaking memory as the returned BSTR is never deallocated.

You could just as easily

VARIANT_BOOL bSuccess = spXMLDOM->loadXML(CComBSTR(xmltext));

Which will handle the memory properly.

As to why its failing - You can ask the DOMDocument for its parseError object IXMLDOMParseError and then fetch the reason from it - that will probably shed more light on what the real problem is.

Answer3:

We use

hr = m_pXMLDoc->load(_variant_t(xml_file.c_str()), &varStatus); hr = m_pXMLDoc->loadXML(_bstr_t(xml_doc.c_str()), &varStatus);

For loading files and raw xml respectively.

Recommend

  • php echo first divs
  • Relative Path to load a library?
  • “ java.lang.IllegalStateException: The driver is not executable” error is coming when TestNG test ca
  • How to remove html part of a text in PHP
  • How to add nodes to a multi-level XML from an array?
  • How do I call DotNetFactory from VBScript in a stand-alone .vbs file?
  • Scala HTML parser object usage
  • PHP XPath. How to return string with html tags?
  • Google Contacts API get phone number (PHP)
  • New BFC “clearing” floating boxes
  • Howto take a glimpse into mscorlib?
  • Searching an XML file using PHP [closed]
  • doPostBack from C# with JavaScript
  • passing a javascript variable to PHP with xmlhttprequest
  • Reading XML into Datatable gives incorrect DateTime when the time has Time Zone info
  • Deleting a widget from QTableView
  • multidatatrigger with multibinding in ControlTemplate.Triggers
  • Is there a parser equivalent of 'fragment' marking in ANTLR4?
  • Build Successful but not running on simulator
  • Unable to install Git-core+svn by MacPorts
  • Appending Character to Character Array In C
  • Unable to decode certificate at client new X509Certificate2()
  • C: Incompatible pointer type initializing
  • The plugin 'org.apache.maven.plugins:maven-jboss-as-plugin' does not exist or no valid ver
  • Launch Runnable Jar from Web Start
  • AES padding and writing the ciphertext to a disk file
  • VS2008 Enable C++ Exception with SEH
  • Convert array of 8 bytes to signed long in C++
  • AT Commands to Send SMS not working in Windows 8.1
  • Comma separated Values
  • Linker errors when using intrinsic function via function pointer
  • Rails 2: use form_for to build a form covering multiple objects of the same class
  • Error creating VM instance in Google Compute Engine
  • Hits per day in Google Big Query
  • Trying to get generic when generic is not available
  • how does django model after text[] in postgresql [duplicate]
  • FormattedException instead of throw new Exception(string.Format(…)) in .NET
  • How do I configure my settings file to work with unit tests?
  • LevelDB C iterator
  • Is it possible to post an object from jquery to bottle.py?